linux-kernel - Re: [PATCH] parisc,metag: Implement CONFIG_DEBUG_STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160429220437.GA15188@jhogan-linux.le.imgtec.org>
Date:	Fri, 29 Apr 2016 23:04:37 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Helge Deller <deller@....de>
CC:	<linux-parisc@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	John David Anglin <dave.anglin@...l.net>,
	<linux-metag@...r.kernel.org>, <linux-ia64@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parisc,metag: Implement CONFIG_DEBUG_STACK_USAGE option

Hi Helge,

On Sat, Mar 19, 2016 at 05:54:10PM +0100, Helge Deller wrote:
> On parisc and metag the stack grows upwards, so for those we need to
> scan the stack downwards in order to calculate how much stack a process
> has used.
> 
> Tested on a 64bit parisc kernel.
> 
> Signed-off-by: Helge Deller <deller@....de>

Looks good, and works on metag too!

Tested-by: James Hogan <james.hogan@...tec.com>
Acked-by: James Hogan <james.hogan@...tec.com>

Cheers
James

> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 084ed9f..71591f3 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -2859,10 +2859,18 @@ static inline unsigned long stack_not_used(struct task_struct *p)
>  	unsigned long *n = end_of_stack(p);
>  
>  	do { 	/* Skip over canary */
> +# ifdef CONFIG_STACK_GROWSUP
> +		n--;
> +# else
>  		n++;
> +# endif
>  	} while (!*n);
>  
> +# ifdef CONFIG_STACK_GROWSUP
> +	return (unsigned long)end_of_stack(p) - (unsigned long)n;
> +# else
>  	return (unsigned long)n - (unsigned long)end_of_stack(p);
> +# endif
>  }
>  #endif
>  extern void set_task_stack_end_magic(struct task_struct *tsk);
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index f28f7fa..901f96c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -546,7 +546,7 @@ config DEBUG_KMEMLEAK_DEFAULT_OFF
>  
>  config DEBUG_STACK_USAGE
>  	bool "Stack utilization instrumentation"
> -	depends on DEBUG_KERNEL && !IA64 && !PARISC && !METAG
> +	depends on DEBUG_KERNEL && !IA64
>  	help
>  	  Enables the display of the minimum amount of free stack which each
>  	  task has ever had available in the sysrq-T and sysrq-P debug output.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)