linux-kernel - Re: [PATCH] char: xillybus: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 30 Apr 2016 17:14:41 +0100
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Eli Billauer <eli.billauer@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: xillybus: use devm_add_action_or_reset

On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
> 
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
> 
>     if (rc)
>         return rc;
> 
>     return 0;
> 
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.

ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.

regards
sudip