linux-kernel - Re: [PATCH] Use existing helper to convert "on/off" to boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160430044716.GA18250@dhcp-128-44.nay.redhat.com>
Date:	Sat, 30 Apr 2016 12:47:16 +0800
From:	Minfei Huang <mnghuan@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	labbott@...oraproject.org, rjw@...ysocki.net,
	mgorman@...hsingularity.net, mhocko@...e.com, vbabka@...e.cz,
	rientjes@...gle.com, kirill.shutemov@...ux.intel.com,
	iamjoonsoo.kim@....com, izumi.taku@...fujitsu.com,
	hannes@...xchg.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use existing helper to convert "on/off" to boolean

On 04/29/16 at 02:21P, Andrew Morton wrote:
> On Fri, 29 Apr 2016 13:47:04 +0800 Minfei Huang <mnghuan@...il.com> wrote:
> 
> > It's more convenient to use existing function helper to convert string
> > "on/off" to boolean.
> > 
> > ...
> >
> > --- a/lib/kstrtox.c
> > +++ b/lib/kstrtox.c
> > @@ -326,7 +326,7 @@ EXPORT_SYMBOL(kstrtos8);
> >   * @s: input string
> >   * @res: result
> >   *
> > - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or
> > + * This routine returns 0 if the first character is one of 'Yy1Nn0', or
> 
> That isn't actually a typo.  "iff" is shorthand for "if and only if". 
> ie: kstrtobool() will not return 0 in any other case.
> 
> Use of "iff" is a bit pretentious but I guess it does convey some
> conceivably useful info.
> 

Got it. Thanks for your explanation.

Thanks
Minfei