linux-kernel - Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160501231745.GD19653@zurbaran.home>
Date:	Mon, 2 May 2016 01:17:45 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Michael Thalmeier <michael.thalmeier@...e.at>
Cc:	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	linux-kernel@...r.kernel.org, linux-nfc@...ts.01.org,
	michael@...lmeier.at
Subject: Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped

Hi Michael,

On Thu, Apr 21, 2016 at 04:43:54PM +0200, Michael Thalmeier wrote:
> When a poll ist stopped we need to kill the out_urb request too before
> starting a new request.
> 
> Additionally check if cmd is set in pn533_recv_ack befor accessing its struct
> members.
I understand those 2 (stopping a poll and cmd being NULL) are not
completely unrelated, but I'd prefer if we could have separate patches
here.

As a matter of fact it seems you're trying to handle a potential NULL
cmd pointer in several of the subsequent patches and I'd like to see all
of those grouped in one patch with an explanation as to why we need to
do this (i.e. how come we can have such pointer being NULL).

Cheers,
Samuel.