linux-kernel - [tip:perf/core] perf tests: Do not use sizeof on pointer type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-ca7ce82a280a65c377c24c95c29b1dec6e80b428@git.kernel.org>
Date:	Sun, 1 May 2016 00:41:53 -0700
From:	tip-bot for Vaishali Thakkar <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	peterz@...radead.org, vaishali.thakkar@...cle.com,
	linux-kernel@...r.kernel.org, hpa@...or.com, acme@...hat.com,
	mingo@...nel.org, tglx@...utronix.de,
	alexander.shishkin@...ux.intel.com
Subject: [tip:perf/core] perf tests: Do not use sizeof on pointer type

Commit-ID:  ca7ce82a280a65c377c24c95c29b1dec6e80b428
Gitweb:     http://git.kernel.org/tip/ca7ce82a280a65c377c24c95c29b1dec6e80b428
Author:     Vaishali Thakkar <vaishali.thakkar@...cle.com>
AuthorDate: Thu, 28 Apr 2016 22:16:57 +0530
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Thu, 28 Apr 2016 15:37:52 -0300

perf tests: Do not use sizeof on pointer type

Using sizeof on a malloced pointer type will return the wordsize which
can often cause one to allocate a buffer much smaller than it is needed.
So, here do not use sizeof on pointer type.

Note that this has no effect on runtime because 'dsos' is a pointer to a
pointer.

Problem found using Coccinelle.

Signed-off-by: Vaishali Thakkar <vaishali.thakkar@...cle.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/1461862017-23358-1-git-send-email-vaishali.thakkar@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/tests/dso-data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index dc673ff..8cf0d9e 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -202,7 +202,7 @@ static int dsos__create(int cnt, int size)
 {
 	int i;
 
-	dsos = malloc(sizeof(dsos) * cnt);
+	dsos = malloc(sizeof(*dsos) * cnt);
 	TEST_ASSERT_VAL("failed to alloc dsos array", dsos);
 
 	for (i = 0; i < cnt; i++) {