linux-kernel - Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOviyaikiTOCveWNuA+Och4SvHnXmZ07s0WDjc-JVo5avm6g-g@mail.gmail.com>
Date:	Sun, 1 May 2016 23:20:53 +1000
From:	Aleksa Sarai <cyphar@...har.com>
To:	Aleksa Sarai <asarai@...e.de>
Cc:	Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>,
	Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, dev <dev@...ncontainers.org>
Subject: Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces

> +err_unset_mode:
> +       /* Clean up the mode changes. */
> +       do_each_subsys_mask(ss, ssid, updated_mask) {
> +               struct kernfs_node *kn = cset->subsys[ssid]->cgroup->kn;
> +
> +               kernfs_break_active_protection(kn);
> +               cgroup_kn_set_mode(kn, mode[ssid]);
> +               kernfs_unbreak_active_protection(kn);
> +       } while_each_subsys_mask();

Sorry, I just realised this doesn't unlock all of the relevant locks
in the error path. I'll send an updated patch.

-- 
Aleksa Sarai (cyphar)
www.cyphar.com