linux-kernel - Re: [PATCH v3] serial: samsung: Reorder the sequence of clock control when call s3c24xx_serial_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPf-5QXcdmApzzZgcd=QEn5bVbtB2w90kxMGLTAz3HRoSw@mail.gmail.com>
Date:	Mon, 2 May 2016 14:04:40 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.com, kgene@...nel.org,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v3] serial: samsung: Reorder the sequence of clock control
 when call s3c24xx_serial_set_termios()

On Thu, Apr 21, 2016 at 11:58 AM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> This patch fixes the broken serial log when changing the clock source
> of uart device. Before disabling the original clock source, this patch
> enables the new clock source to protect the clock off state for a split second.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Reviewed-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
> Changes from v2:
> - Add reviewd-by tag from Marek Szyprowski
> - No changes about operation
>
> Changes from v1:
> - Enable the clock before changing the source by s3c24xx_serial_setsource()
> - Rebase it on Linux v4.6-rc1
>
>  drivers/tty/serial/samsung.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Fixes synchronous abort on our Exynos5433-based board. This should be
marked for cc-stable. I'll send a port for that.

BR,
Krzysztof