linux-kernel - Re: [PATCH 1/7] iio: inv_mpu6050: Do burst reads using spi/i2c directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160502152442.GH6292@sirena.org.uk>
Date:	Mon, 2 May 2016 16:24:42 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Crestez Dan Leonard <leonard.crestez@...el.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Ge Gao <GGao@...ensense.com>
Subject: Re: [PATCH 1/7] iio: inv_mpu6050: Do burst reads using spi/i2c
 directly

On Sun, May 01, 2016 at 06:11:50PM +0100, Jonathan Cameron wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

>  On 29/04/16 20:02, Crestez Dan Leonard wrote:
> > Using regmap_read_bulk is wrong because it assumes that a range of
> > registers is being read. In our case reading from the fifo register will
> > return multiple values but this is *not* auto-increment.

> > This currently works by accident.

> Cc'd Mark again.  He's the regmap maintainer (amongst other things) so
> a series doing slightly odd things with regmap should probably have been
> cc'd to him in the first place.

> Perhaps regmap should have a repeat read function for this sort of fifo access?
> Mark, is this something you'd consider?  Easy enough to implement after all as
> a variant on regmap_read_bulk...

> Having the below in a driver just feels wrong to me....

That doesn't sound like a crazy idea, please send patches for proposed
extensions.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)