[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5727A875.6010003@plexistor.com>
Date: Mon, 02 May 2016 22:20:21 +0300
From: Boaz Harrosh <boaz@...xistor.com>
To: Toshi Kani <toshi.kani@....com>, dan.j.williams@...el.com,
jack@...e.cz, david@...morbit.com
CC: hch@...radead.org, tytso@....edu, adilger.kernel@...ger.ca,
ross.zwisler@...ux.intel.com, micah.parrish@....com,
linux-nvdimm@...ts.01.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Add alignment check for DAX mount
On 05/02/2016 09:42 PM, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,
> but any read/write access to the filesystem fails, except for
> metadata update.
>
> Add alignment check to ext4, ext2, and xfs.
>
> v2:
> - Use a helper function via ->direct_access for the check.
> (Christoph Hellwig)
> - Call bdev_direct_access() with sector 0 for the check.
> (Boaz Harrosh)
>
> ---
> Toshi Kani (3):
> 1/3 ext4: Add alignment check for DAX mount
> 2/3 ext2: Add alignment check for DAX mount
> 3/3 xfs: Add alignment check for DAX mount
>
All patches look very good to me, and keep the
internals internal. Thanks Toshi
Review-by: Boaz Harrosh <boaz@...xistor.com>
> ---
> fs/ext2/super.c | 21 +++++++++++++++++++--
> fs/ext4/super.c | 20 ++++++++++++++++++--
> fs/xfs/xfs_super.c | 23 +++++++++++++++++++----
> 3 files changed, 56 insertions(+), 8 deletions(-)
>
Powered by blists - more mailing lists