linux-kernel - Re: [PATCH] modpost: fix module autoloading for OF devices with generic compatible property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160502145320.f4529b37b32c9ec0a9fc96e1@linux-foundation.org>
Date:	Mon, 2 May 2016 14:53:20 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>,
	Brian Norris <computersforpeace@...il.com>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel@...gutronix.de
Subject: Re: [PATCH] modpost: fix module autoloading for OF devices with
 generic compatible property

On Mon,  2 May 2016 17:35:39 +0200 Philipp Zabel <p.zabel@...gutronix.de> wrote:

> Since the wildcard at the end of OF module aliases is gone, autoloading
> of modules that don't match a device's last (most generic) compatible value
> fails.
> 
> For example the CODA960 VPU on i.MX6Q has the SoC specific compatible
> "fsl,imx6q-vpu" and the generic compatible "cnm,coda960". Since the driver
> currently only works with knowledge about the SoC specific integration,
> it doesn't list "cnm,cod960" in the module device table.
> This results in the device compatible
> "of:NvpuT<NULL>Cfsl,imx6q-vpuCcnm,coda960" not matching the module alias
> "of:N*T*Cfsl,imx6q-vpu" anymore, whereas before commit 2f632369ab79
> ("modpost: don't add a trailing wildcard for OF module aliases") it
> matched the module alias "of:N*T*Cfsl,imx6q-vpu*".
> 
> This patch adds two module aliases for each compatible, one without the
> wildcard and one with "C*" appended.
> 
>   $ modinfo coda | grep imx6q
>   alias:          of:N*T*Cfsl,imx6q-vpuC*
>   alias:          of:N*T*Cfsl,imx6q-vpu

I added this:

Cc: <stable@...r.kernel.org>    [4.5+]