linux-kernel - Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5726F108.2050805@nvidia.com>
Date:	Mon, 2 May 2016 11:47:44 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
	Paweł Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dia.com>,
	Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024


On Saturday 30 April 2016 05:08 PM, Linus Walleij wrote:
> On Thu, Apr 28, 2016 at 11:59 AM, Laxman Dewangan <ldewangan@...dia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
>> pins. It also supports interrupts from these pins.
>>
>> Add GPIO driver for these pins to control via GPIO APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Gnah there is still a problem with this, I just saw it:
>
>> +config GPIO_MAX77620
>> +       bool "GPIO support for PMIC MAX77620 and MAX20024"
> bool == not a module

Yaah, looked the changes from Gortmaker.
The things are evolving faster.

I think we can change "bool" to "tristate" here.
Then there is no need to have code change. MFD driver is already said as 
tristate.


I will wait for Lee's comment on this series patch before recycling the 
patch. (Already on V11 :-(  ).