linux-kernel - Re: [PATCH] lightnvm: pass dma address to hardware rather than pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E3EC5236-A5C4-4D52-9BE3-9BF382434D46@cnexlabs.com>
Date:	Tue, 3 May 2016 16:14:42 +0000
From:	Javier González <javier@...xlabs.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
	Matias Bjørling <m@...rling.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: pass dma address to hardware rather than
 pointer

> 
> On 03 May 2016, at 17:22, Arnd Bergmann <arnd@...db.de> wrote:
> 
> A recent change to lightnvm added code to pass a kernel pointer
> to the hardware, which gcc complained about:
> 
> drivers/nvme/host/lightnvm.c: In function 'nvme_nvm_rqtocmd':
> drivers/nvme/host/lightnvm.c:472:32: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>  c->ph_rw.metadata = cpu_to_le64(rqd->meta_list);
> 
> It looks like this has no way of working anyway, so this changes
> the code to pass the dma_address instead. This was most likely
> what was intended here. Neither of the two are currently ever
> written to, so the effect is the same for now.
> 

Thanks Arnd.

It was my mistake. I had it fixed in the pblk branch, where we use the
metadata field and was waiting to send it together with other fixes.

Javier.

Download attachment "signature.asc" of type "application/pgp-signature" (843 bytes)