linux-kernel - Re: [tip:core/signals] selftests/sigaltstack: Add new testcase for sigaltstack(SS_ONSTACK|SS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUOjfp8xTBxEyFyax9GSa=JQfG0JB=kVqGwUR-yHU97PQ@mail.gmail.com>
Date:	Tue, 3 May 2016 09:43:43 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Denys Vlasenko <dvlasenk@...hat.com>, Stas Sergeev <stsp@...t.ru>,
	Peter Zijlstra <peterz@...radead.org>,
	Shuah Khan <shuahkh@....samsung.com>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Brian Gerst <brgerst@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Ingo Molnar <mingo@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Pavel Emelyanov <xemul@...allels.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:core/signals] selftests/sigaltstack: Add new testcase for sigaltstack(SS_ONSTACK|SS_AUTODISARM)

On Tue, May 3, 2016 at 12:50 AM, tip-bot for Stas Sergeev
<tipbot@...or.com> wrote:
> Commit-ID:  19fd2868e3671b446b13d135a44363182bbd319a
> Gitweb:     http://git.kernel.org/tip/19fd2868e3671b446b13d135a44363182bbd319a
> Author:     Stas Sergeev <stsp@...t.ru>
> AuthorDate: Thu, 14 Apr 2016 23:20:05 +0300
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Tue, 3 May 2016 08:37:59 +0200
>
> selftests/sigaltstack: Add new testcase for sigaltstack(SS_ONSTACK|SS_AUTODISARM)
>
> This patch adds the test case for SS_AUTODISARM flag.
> The test-case tries to set SS_AUTODISARM flag and checks if
> the nested signal corrupts the stack after swapcontext().


> +       stk.ss_sp = sstack;
> +       stk.ss_size = SIGSTKSZ;
> +       stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
> +       err = sigaltstack(&stk, NULL);
> +       if (err) {
> +               perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
> +               stk.ss_flags = SS_ONSTACK;

This code path here is wrong.  I'll send a fix.

--Andy