| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 May 2016 00:28:08 +0530 From: Muhammad Falak R Wani <falakreyaz@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] crypto: algif_skcipher: replace sg++ with sg_next() Never use sg++, always use sg = sg_next(sg). Scatterlist entries can be combined if the memory is contiguous but sg++ won't know about that. It sure would run on the slower side. But regardless, sg++ should never be used, only sg_next is safe. Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com> --- crypto/algif_skcipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index 28556fc..a668867 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -489,7 +489,7 @@ static int skcipher_all_sg_nents(struct skcipher_ctx *ctx) sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); nents += sg_nents(sg); } @@ -553,7 +553,7 @@ static int skcipher_recvmsg_async(struct socket *sock, struct msghdr *msg, sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); used = min_t(unsigned long, ctx->used, iov_iter_count(&msg->msg_iter)); @@ -676,7 +676,7 @@ static int skcipher_recvmsg_sync(struct socket *sock, struct msghdr *msg, sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); skcipher_request_set_crypt(&ctx->req, sg, ctx->rsgl.sg, used, ctx->iv); -- 1.9.1
Powered by blists - more mailing lists