linux-kernel - Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160503202857.GA3997@linux.intel.com>
Date:	Tue, 3 May 2016 14:28:57 -0600
From:	Ross Zwisler <ross.zwisler@...ux.intel.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix

On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote:
> radix_tree_locate_item() is often returning the wrong index, causing
> swapoff of shmem to hang because it cannot find the swap entry there.
> __locate()'s use of base is bogus, it adds an offset twice into index.
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>

Thank you for the fix!

Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>