linux-kernel - Re: [PATCH] Staging: dgnc: fix coding style in dgnc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 14:08:21 -0700
From:	Greg KH <greg@...ah.com>
To:	Patryk Mezydlo <mezydlo.p@...il.com>
Cc:	mwelling@...e.org, linux-kernel@...r.kernel.org,
	lidza.louina@...il.com
Subject: Re: [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c

On Tue, May 03, 2016 at 08:37:27PM +0200, Patryk Mezydlo wrote:
> Fix checkpatch.pl warning about 'line over 80 characters'.
> I just split line with function.
> 
> Signed-off-by: Patryk Mezydlo <mezydlo.p@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index 9aa0ba0..b818b0a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd)
>  	if (IS_ERR(brd->serial_driver))
>  		return PTR_ERR(brd->serial_driver);
>  
> -	snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum);
> +	snprintf(brd->serial_name, MAXTTYNAMELEN,
> +		"tty_dgnc_%d_", brd->boardnum);

Why move the string to a new line?  It didn't need to be there, did it?