[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160503230629.GB15078@kroah.com>
Date: Tue, 3 May 2016 16:06:29 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Kangjie Lu <kangjielu@...il.com>
Cc: johnny.kim@...el.com, austin.shin@...el.com, chris.park@...el.com,
tony.cho@...el.com, glen.lee@...el.com,
linux-kernel@...r.kernel.org, taesoo@...ech.edu, insu@...ech.edu,
csong84@...ech.edu, Kangjie Lu <kjlu@...ech.edu>
Subject: Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations
On Tue, May 03, 2016 at 06:17:28PM -0400, Kangjie Lu wrote:
> "mac" is an array allocated in stack without being initialized,
> and will be sent out via "nla_put". The dump_station() is supposed
> to initialize the mac address; otherwise, sensitive data in kernel
> stack will be leaked. To fix this, initialize it with memset or
> fill it with meaningful mac address.
"or"? You just set it to zero, why not fix this correctly and put the
real address here?
thanks,
greg k-h
Powered by blists - more mailing lists