linux-kernel - Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1462248309.12788.4.camel@ellerman.id.au>
Date:	Tue, 03 May 2016 14:05:09 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Arnd Bergmann <arnd@...db.de>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	geert@...ux-m68k.org, deller@....de, benh@...nel.crashing.org,
	dalias@...c.org, dhowells@...hat.com, linux-alpha@...r.kernel.org,
	a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-sh@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
	rtc-linux@...glegroups.com, linux-arch@...r.kernel.org
Subject: Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class_ops directly

On Thu, 2016-04-28 at 00:34 +0200, Arnd Bergmann wrote:

> The rtc-generic driver provides an architecture specific
> wrapper on top of the generic rtc_class_ops abstraction,
> and powerpc has another abstraction on top, which is a bit
> silly.
> 
> This changes the powerpc rtc-generic device to provide its
> rtc_class_ops directly, to reduce the number of layers
> by one.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/powerpc/kernel/time.c | 29 ++++++++++++++++++++++++++++-
>  drivers/rtc/rtc-generic.c  |  2 +-
>  2 files changed, 29 insertions(+), 2 deletions(-)

If this hits linux-next it will go through my automated boot testing, which
hopefully would be sufficient to catch any bugs in this patch, cross fingers.

I don't know jack about all the layers of RTC mess, so my ack is basically
worthless here. But if you like you can have one anyway :)

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers