linux-kernel - Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160503092348.09a9e71c@mschwide>
Date:	Tue, 3 May 2016 09:23:48 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Anna-Maria Gleixner <anna-maria@...utronix.de>,
	linux-kernel@...r.kernel.org, rt@...utronix.de,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

On Mon, 2 May 2016 12:43:56 +0200
Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> On Mon, May 02, 2016 at 11:00:12AM +0200, Anna-Maria Gleixner wrote:
> > Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
> > in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
> > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> > function calls are no longer required.
> > 
> > Replace smp_call_function_single() with a direct call of
> > setup_pmc_cpu(). To keep the calling convention, interrupts are
> > explicitly disabled around the call.
> > 
> > Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> > Cc: linux-s390@...r.kernel.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
> > ---
> > Changes in v2:
> > 	- Adapt referenced commit in commit message
> > 
> >  arch/s390/kernel/perf_cpum_sf.c |    9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> Same here: Martin, can you pick this one up, please?

Applied as well.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.