linux-kernel - Re: [PATCH v3] iio: accel: Add support for Freescale MMA7660FC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 10:29:26 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Constantin Musca <constantin.musca@...el.com>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [PATCH v3] iio: accel: Add support for Freescale MMA7660FC

On Sun, May 1, 2016 at 9:56 PM, Jonathan Cameron <jic23@...nel.org> wrote:
> On 29/04/16 13:19, Constantin Musca wrote:
>> Minimal implementation of an IIO driver for the Freescale
>> MMA7660FC 3-axis accelerometer. Datasheet:
>> http://www.freescale.com.cn/files/sensors/doc/data_sheet/MMA7660FC.pdf
>>
>> Includes:
>> - ACPI support;
>> - read_raw for x,y,z axes;
>> - reading and setting the scale (range) parameter.
>> - power management
>>
>> Signed-off-by: Constantin Musca <constantin.musca@...el.com>
> Couple of trivial bits inline as well as that request to update the link above
> if possible...
>
> Why the retries? (I'm on a train without internet access for quite a few
> hours yet hence I can't dig into the datasheet!)

I suggested the retries because it's quite unsafe to infinitely loop
in the kernel
on a hardware condition. We can lockup the kernel if there is some sort of
hardware problem.


>
> Anyhow, even if it's obvious from the datasheet, that sort of 'magic' needs
> an explanation comment...