linux-kernel - Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57285A0F.7060603@sakamocchi.jp>
Date:	Tue, 3 May 2016 16:58:07 +0900
From:	Takashi Sakamoto <o-takashi@...amocchi.jp>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"Subhransu S. Prusty" <subhransu.s.prusty@...el.com>
Cc:	alsa-devel@...a-project.org, Arnd Bergmann <arnd@...db.de>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>,
	Jeeja KP <jeeja.kp@...el.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in
 hdac_hdmi_get_spk_alloc()

On May 03 2016 16:42, Dan Carpenter wrote:
> We intended || here instead of &&.  The original code potentially leads
> to a NULL dereference.
> 
> Fixes: 2889099eb8cd ('ASoC: hdac_hdmi: Register chmap controls and ops')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Indeed.

Reviewd-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

> diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
> index 3043120..7e7ff1b 100644
> --- a/sound/soc/codecs/hdac_hdmi.c
> +++ b/sound/soc/codecs/hdac_hdmi.c
> @@ -1609,7 +1609,7 @@ static int hdac_hdmi_get_spk_alloc(struct hdac_device *hdac, int pcm_idx)
>  	struct hdac_hdmi_pcm *pcm = get_hdmi_pcm_from_id(hdmi, pcm_idx);
>  	struct hdac_hdmi_pin *pin = pcm->pin;
>  
> -	if (!pin && !pin->eld.eld_valid)
> +	if (!pin || !pin->eld.eld_valid)
>  		return 0;
>  
>  	return pin->eld.info.spk_alloc;


Regards

Takashi Sakamoto