[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160503081806.GE14148@phenom.ffwll.local>
Date: Tue, 3 May 2016 10:18:06 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Stefan Agner <stefan@...er.ch>
Cc: Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>,
Alison Wang <alison.wang@...escale.com>,
linux-arm-kernel@...ts.infradead.org,
dri-devel@...ts.freedesktop.org,
Xiubo Li <lixiubo@...s.chinamobile.com>,
Daniel Vetter <daniel.vetter@...ll.ch>,
Jianwei Wang <jianwei.wang.chn@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/fsl-dcu: add COMMON_CLK dependency
On Mon, May 02, 2016 at 02:22:04PM -0700, Stefan Agner wrote:
> On 2016-05-02 04:00, Arnd Bergmann wrote:
> > The fsl dcu now uses the clk-provider interfaces, which are not available
> > when CONFIG_COMMON_CLK is disabled:
> >
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe':
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit
> > declaration of function '__clk_get_name'
> > [-Werror=implicit-function-declaration]
> > pix_clk_in_name = __clk_get_name(pix_clk_in);
> >
> > This adds a Kconfig dependency to prevent the driver from being enabled
> > in this case.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for
> > pixel clock divider")
>
> Oh right, thx!
>
> Acked-by: Stefan Agner <stefan@...er.ch>
>
> @Dave, can you pick that up directly or do you prefer a pull request?
Smashed into drm-misc, thanks.
-Daniel
>
> --
> Stefan
>
> > ---
> > drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> > index c78cf3f605d0..b9c714de6e40 100644
> > --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> > +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> > @@ -1,6 +1,6 @@
> > config DRM_FSL_DCU
> > tristate "DRM Support for Freescale DCU"
> > - depends on DRM && OF && ARM
> > + depends on DRM && OF && ARM && COMMON_CLK
> > select BACKLIGHT_CLASS_DEVICE
> > select BACKLIGHT_LCD_SUPPORT
> > select DRM_KMS_HELPER
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists