linux-kernel - Re: [PATCH v2 06/12] documentation: Add scheduler/sched-avg.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 10:50:16 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Yuyang Du <yuyang.du@...el.com>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org, bsegall@...gle.com,
	pjt@...gle.com, morten.rasmussen@....com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	juri.lelli@....com
Subject: Re: [PATCH v2 06/12] documentation: Add scheduler/sched-avg.txt

On Tue, May 03, 2016 at 05:54:32AM +0800, Yuyang Du wrote:
> This doc file has the programs to generate the constants to compute
> sched averages.
> 
> Signed-off-by: Yuyang Du <yuyang.du@...el.com>
> ---
>  Documentation/scheduler/sched-avg.txt |  137 +++++++++++++++++++++++++++++++++
>  1 file changed, 137 insertions(+)
>  create mode 100644 Documentation/scheduler/sched-avg.txt
> 
> diff --git a/Documentation/scheduler/sched-avg.txt b/Documentation/scheduler/sched-avg.txt
> new file mode 100644
> index 0000000..ae4132f
> --- /dev/null
> +++ b/Documentation/scheduler/sched-avg.txt
> @@ -0,0 +1,137 @@
> +The following programs are used to generate the constants for
> +computing sched averages.
> +
> +==============================================================
> +		C program (compile with -lm)
> +==============================================================

> +==============================================================
> +		Python script if you speak snake
> +==============================================================

Please do not put two programs in one file. Also, I think I would prefer
it to be one program; having two just means they can drift apart and
create confusion.