linux-kernel - Re: [PATCH 1/4] thermal: Add support for hardware-tracked trip points

Open Source and information security mailing list archives

Date:	Tue, 3 May 2016 17:25:47 +0800
From:	Caesar Wang <caesar.upstream@...il.com>
To:	Eduardo Valentin <edubezval@...il.com>
Cc:	Caesar Wang <wxt@...k-chips.com>, huangtao@...k-chips.com,
	Heiko Stuebner <heiko@...ech.de>, linux-pm@...r.kernel.org,
	Sascha Hauer <s.hauer@...gutronix.de>,
	dmitry.torokhov@...il.com, dianders@...omium.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	eddie.cai@...k-chips.com, smbarber@...gle.com,
	briannorris@...gle.com, Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH 1/4] thermal: Add support for hardware-tracked trip points

在 2016年04月28日 05:48, Eduardo Valentin 写道:
> This patch is based on an earlier version from Mikko Perttunen
> <mikko.perttunen@...si.fi>
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: linux-pm@...r.kernel.org
> ---
>
>   drivers/thermal/thermal_core.c | 48 ++++++++++++++++++++++++++++++++++++++++++
>   include/linux/thermal.h        |  3 +++
>>
>
>   static void update_temperature(struct thermal_zone_device *tz)
>   {
>   	int temp, ret;
> @@ -569,6 +610,8 @@ void thermal_zone_device_update(struct thermal_zone_device *tz)
>   
>   	update_temperature(tz);
>   
> +	thermal_zone_set_trips(tz);
> +
>   	for (count = 0; count < tz->trips; count++)
>   		handle_thermal_trip(tz, count);
>   }
> @@ -754,6 +797,9 @@ trip_point_hyst_store(struct device *dev, struct device_attribute *attr,
>   	 */
>   	ret = tz->ops->set_trip_hyst(tz, trip, temperature);
>   
> +	if (!ret)
> +		thermal_zone_set_trips(tz);
> +
> You would probably want to do the same on trip_point_temp_store().
>

Sorry, that has been set in thermal_zone_device_update().

static ssize_t trip_point_temp_store()
{
     ..
     thermal_zone_device_update(tz);
     ..
}

> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

-- 
Thanks,
Caesar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives