linux-kernel - Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 15:21:39 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Pramod Gurav <pramod.gurav@...aro.org>
Cc:	vinod.koul@...el.com, andy.gross@...aro.org,
	ulf.hansson@...aro.org, rjw@...ysocki.net,
	linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dmaengine@...r.kernel.org, stanimir.varbanov@...aro.org,
	okaya@...eaurora.org
Subject: Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

Hi Pramod

> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan)
>         struct bam_device *bdev = bchan->bdev;
>         unsigned long flag;
>
> +       pm_runtime_get_sync(bdev->dev);
>         spin_lock_irqsave(&bchan->vc.lock, flag);
>         writel_relaxed(0, bam_addr(bdev, bchan->id, BAM_P_HALT));
>         bchan->paused = 0;
>         spin_unlock_irqrestore(&bchan->vc.lock, flag);
> +       pm_runtime_mark_last_busy(bdev->dev);
> +       pm_runtime_put_autosuspend(bdev->dev);
>
>         return 0;
>  }

Why this function simply return 'success' without any error capture?

> @@ -1252,16 +1278,76 @@ static int bam_dma_remove(struct platform_device *pdev)
>
>         tasklet_kill(&bdev->task);
>
> +       pm_runtime_get_sync(&pdev->dev);
>         clk_disable_unprepare(bdev->bamclk);
> +       pm_runtime_disable(&pdev->dev);
> +       pm_runtime_put_noidle(&pdev->dev);
> +       pm_runtime_set_suspended(&pdev->dev);
> +
> +       return 0;
> +}

Why this function simply return 'success' without any error capture?

> +static int bam_dma_runtime_suspend(struct device *dev)
> +{
> +       struct bam_device *bdev = dev_get_drvdata(dev);
> +
> +       clk_disable(bdev->bamclk);
> +
> +       return 0;
> +}

Why this function simply return 'success' without any error capture?


> +#ifdef CONFIG_PM_SLEEP
> +static int bam_dma_suspend(struct device *dev)
> +{
> +       struct bam_device *bdev = dev_get_drvdata(dev);
> +
> +       pm_runtime_force_suspend(dev);
> +
> +       clk_unprepare(bdev->bamclk);
>
>         return 0;
>  }

Why this function simply return 'success' without any error capture?

Regards
Manish Badarkhe