linux-kernel - Re: rtlwifi: rtl818x: Deinline indexed IO functions, save 21568 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160503100557.76E7A60239@smtp.codeaurora.org>
Date:	Tue,  3 May 2016 10:05:57 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	unlisted-recipients:; (no To-header on input)
	Denys Vlasenko <dvlasenk@...hat.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: rtlwifi: rtl818x: Deinline indexed IO functions, save 21568 bytes


> rtl818x_ioread8_idx: 151 bytes, 29 calls
> rtl818x_ioread16_idx: 151 bytes, 11 calls
> rtl818x_ioread32_idx: 151 bytes, 5 calls
> rtl818x_iowrite8_idx: 157 bytes, 117 calls
> rtl818x_iowrite16_idx: 158 bytes, 74 calls
> rtl818x_iowrite32_idx: 157 bytes, 22 calls
> 
> Each of these functions has a pair of mutex lock/unlock ops,
> both of these ops perform atomic updates of memory (on x86, it boils down to
> "lock cmpxchg %reg,mem" insn), which are 4-8 times more expensive than call+return.
> 
>     text     data      bss       dec     hex filename
> 95894242 20860288 35991552 152746082 91ab862 vmlinux_before
> 95872674 20860320 35991552 152724546 91a6442 vmlinux
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Larry Finger <Larry.Finger@...inger.net>
> CC: Chaoming Li <chaoming_li@...lsil.com.cn>
> CC: linux-wireless@...r.kernel.org
> CC: linux-kernel@...r.kernel.org

Thanks, applied to wireless-drivers-next.git.

Kalle Valo