linux-kernel - Re: [PATCH] reset: fix Kconfig menu to include reset drivers in sub-menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1462270673.3617.50.camel@pengutronix.de>
Date:	Tue, 03 May 2016 12:17:53 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Patrice Chotard <patrice.chotard@...com>, kernel@...inux.com,
	Maxime Coquelin <maxime.coquelin@...com>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] reset: fix Kconfig menu to include reset drivers in
 sub-menu

Am Dienstag, den 03.05.2016, 15:29 +0900 schrieb Masahiro Yamada:
> In "make menuconfig", reset drivers are currently lined up together
> with the reset sub-system menu, like this:
> 
>     -*- Reset Controller Support  ----
>     < > Hi6220 Reset Driver
> 
> (It also means, the menu "Reset Controller Support" is always empty.)

Unless ARCH_HISI is enabled it still will be empty.

> "Hi6220 Reset Driver" should go into the sub-menu of the
> "Reset Controller Support".
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/reset/Kconfig     | 4 ++++
>  drivers/reset/sti/Kconfig | 1 -
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index df37212..6a0b24b 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -12,5 +12,9 @@ menuconfig RESET_CONTROLLER
>  
>  	  If unsure, say no.
>  
> +if RESET_CONTROLLER
> +
>  source "drivers/reset/sti/Kconfig"
>  source "drivers/reset/hisilicon/Kconfig"
> +
> +endif
> diff --git a/drivers/reset/sti/Kconfig b/drivers/reset/sti/Kconfig
> index f8c15a3..6131785 100644
> --- a/drivers/reset/sti/Kconfig
> +++ b/drivers/reset/sti/Kconfig
> @@ -2,7 +2,6 @@ if ARCH_STI
>  
>  config STI_RESET_SYSCFG
>  	bool
> -	select RESET_CONTROLLER
>  
>  config STIH415_RESET
>  	bool

Looks good to me. ARCH_STI already selects RESET_CONTROLLER and nothing
selects COMMON_RESET_HI6220.

regards
Philipp