linux-kernel - Re: [PATCH v2] rtc: stmp3xxx: print message on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160503114038.GG2335@piout.net>
Date:	Tue, 3 May 2016 13:40:38 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH v2] rtc: stmp3xxx: print message on error

On 30/04/2016 at 20:11:30 +0100, Sudip Mukherjee wrote :
> stmp3xxx_wdt_register() can fail as platform_device_alloc() or
> platform_device_add() can fail. But when it fails it failed silently.
> Lets print out an error message on failure so that user will atlest
> know that there was some error.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> ---
> 
> v1 -  returned error while failing in the probe.
> 
>  drivers/rtc/rtc-stmp3xxx.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com