linux-kernel - RE: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 12:11:53 +0000
From:	Konstantin Shkolnyy <Konstantin.Shkolnyy@...abs.com>
To:	David Laight <David.Laight@...LAB.COM>,
	'Konstantin Shkolnyy' <konstantin.shkolnyy@...il.com>,
	"johan@...nel.org" <johan@...nel.org>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to
 CRTSCTS flag code.

> -----Original Message-----
> From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-
> owner@...r.kernel.org] On Behalf Of David Laight
> Sent: Tuesday, May 03, 2016 04:44
> To: 'Konstantin Shkolnyy'; johan@...nel.org
> Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to
> CRTSCTS flag code.
> 
> From: Konstantin Shkolnyy
> > Sent: 30 April 2016 03:22
> > Replaced magic numbers used in the CRTSCTS flag code with symbolic
> names
> > from the chip specification.
> >
> > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
> > ---
> > Changes in v2:
> > Improved CRTSCTS fix based on feedback. Dropped get_termios error
> handling.
> >
> >  drivers/usb/serial/cp210x.c | 93
> +++++++++++++++++++++++++++++++++------------
> >  1 file changed, 69 insertions(+), 24 deletions(-)
> >
> > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> ...
> > +/* cp210x_flow_ctl::ulControlHandshake */
> > +#define SERIAL_DTR_MASK		0x00000003
> > +#define SERIAL_CTS_HANDSHAKE	0x00000008
> > +#define SERIAL_DSR_HANDSHAKE	0x00000010
> > +#define SERIAL_DCD_HANDSHAKE	0x00000020
> > +#define SERIAL_DSR_SENSITIVITY	0x00000040
> ...
> 
> I'd have thought the names ought to start CP210X_
> 

These names are inherited from the Labs chip spec.