linux-kernel - Re: [PATCH 3/6] soc/tegra: pmc: Add support for IO pads power state and voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5728A282.5020208@nvidia.com>
Date:	Tue, 3 May 2016 18:37:14 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Jon Hunter <jonathanh@...dia.com>, <swarren@...dotorg.org>,
	<linus.walleij@...aro.org>, <gnurou@...il.com>,
	<robh+dt@...nel.org>, <mark.rutland@....com>,
	<thierry.reding@...il.com>
CC:	<linux-tegra@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 3/6] soc/tegra: pmc: Add support for IO pads power state
 and voltage


On Tuesday 03 May 2016 06:42 PM, Jon Hunter wrote:
> On 03/05/16 13:48, Laxman Dewangan wrote:
>> On Tuesday 03 May 2016 06:25 PM, Jon Hunter wrote:
>>>> Currently SOR driver is using the tegra_io_rail_power_off/on() APIs.
>>>> Once the proper interface available then I will move sor driver to use
>>>> new method and then we can full get rid of older APIs and macros.
>>>>
>>>> Till that, we need to have this.
>>> I prefer it is done before this series. In other words, if we need a
>>> proper enum for the rail/pad IDs then add one and convert any existing
>>> drivers over to use any new APIs first.
>> But the converting to new API can be done after this patch only.
> Yes but before you add the pinctrl driver. May be you should separate
> the two.
>
> My point is that any follow-up series to this, would have to touch the
> pmc and the sor driver. So why not make the changes for the pmc and sor
> now, and once in place then add the pinctrl driver?

I will be happy on this approach also. I added pincontrol driver for 
following purpose:
- To show how new APIs used. This will help on understanding of need and 
whole as a design.
- To get reviewed the whole design/method.
- To get accepted the pmc changes on this cycle so that if possible, we 
can have pincntrl driver in next cycle to avoid cross subsystem approach.