linux-kernel - Re: [PATCH v2 01/29] radix-tree: Introduce radix_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160503142454.GE25436@quack2.suse.cz>
Date:	Tue, 3 May 2016 16:24:54 +0200
From:	Jan Kara <jack@...e.cz>
To:	Matthew Wilcox <willy@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org,
	Konstantin Khlebnikov <koct9i@...il.com>,
	Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
	Jan Kara <jack@...e.com>, Neil Brown <neilb@...e.de>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>
Subject: Re: [PATCH v2 01/29] radix-tree: Introduce radix_tree_empty

On Thu 14-04-16 10:16:22, Matthew Wilcox wrote:
> The irqdomain code was checking for 0 or 1 entries, not 0 entries like
> the comment said they were.  Introduce a new helper that will actually
> check for an empty tree.
> 
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
> Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/radix-tree.h | 5 +++++
>  kernel/irq/irqdomain.c     | 7 +------
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
> index 51a97ac..83f708e 100644
> --- a/include/linux/radix-tree.h
> +++ b/include/linux/radix-tree.h
> @@ -136,6 +136,11 @@ do {									\
>  	(root)->rnode = NULL;						\
>  } while (0)
>  
> +static inline bool radix_tree_empty(struct radix_tree_root *root)
> +{
> +	return root->rnode == NULL;
> +}
> +
>  /**
>   * Radix-tree synchronization
>   *
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 3a519a0..ba3f60d 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -139,12 +139,7 @@ void irq_domain_remove(struct irq_domain *domain)
>  {
>  	mutex_lock(&irq_domain_mutex);
>  
> -	/*
> -	 * radix_tree_delete() takes care of destroying the root
> -	 * node when all entries are removed. Shout if there are
> -	 * any mappings left.
> -	 */
> -	WARN_ON(domain->revmap_tree.height);
> +	WARN_ON(!radix_tree_empty(&domain->revmap_tree));
>  
>  	list_del(&domain->link);
>  
> -- 
> 2.8.0.rc3
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR