linux-kernel - Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160503152111.GC19539@ulmo.ba.sec>
Date:	Tue, 3 May 2016 17:21:11 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Wei Ni <wni@...dia.com>
Cc:	robh+dt@...nel.org, swarren@...dotorg.org,
	linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse
 node

On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
> This patch changes the compatible of Tegra132 fuse node
> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
> Tegra132, the fuse driver can't find the corresponding node.

Okay, that's not really a good reason to modify the DTS. What we should
do instead is make sure that the OF table contains the entry on Tegra132
builds. Unless the IP block really is different and Tegra124 and
Tegra132 aren't compatible in this regard after all.

In the latter case the commit message should reflect the real reason.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)