linux-kernel - Re: [PATCH] gre6: add Kconfig dependency for NET_IPGRE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S35GfPybU-0UrEhh8wopv0rv6d_1+aMHzJ-L-9yM7d8a=Q@mail.gmail.com>
Date:	Tue, 3 May 2016 08:24:23 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Thomas Egerer <hakke_007@....de>,
	Paolo Abeni <pabeni@...hat.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gre6: add Kconfig dependency for NET_IPGRE_DEMUX

On Tue, May 3, 2016 at 8:19 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The ipv6 gre implementation was cleaned up to share more code
> with the ipv4 version, but it can be enabled even when NET_IPGRE_DEMUX
> is disabled, resulting in a link error:
>
> net/built-in.o: In function `gre_rcv':
> :(.text+0x17f5d0): undefined reference to `gre_parse_header'
> ERROR: "gre_parse_header" [net/ipv6/ip6_gre.ko] undefined!
>
> This adds a Kconfig dependency to prevent that now invalid
> configuration.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 308edfdf1563 ("gre6: Cleanup GREv6 receive path, call common GRE functions")
> ---

Acked-by: Tom Herbert <tom@...bertland.com>

>  net/ipv6/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index 11e875ffd7ac..3f8411328de5 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -218,6 +218,7 @@ config IPV6_GRE
>         tristate "IPv6: GRE tunnel"
>         select IPV6_TUNNEL
>         select NET_IP_TUNNEL
> +       depends on NET_IPGRE_DEMUX
>         ---help---
>           Tunneling means encapsulating data of one protocol type within
>           another protocol and sending it over a channel that understands the
> --
> 2.7.0
>