linux-kernel - Re: [PATCH] efivarfs: merge boolean flag arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160503153520.GB2839@codeblueprint.co.uk>
Date:	Tue, 3 May 2016 16:35:20 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	kernel-janitors@...r.kernel.org, Jeremy Kerr <jk@...abs.org>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	vaishali.thakkar@...cle.com, saurabh.truth@...il.com
Subject: Re: [PATCH] efivarfs: merge boolean flag arguments

On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote:
> The parameters atomic and duplicates of efivar_init always have opposite
> values.  Drop the parameter atomic, replace the uses of !atomic with
> duplicates, and update the call sites accordingly.
> 
> The code using duplicates is slightly reorganized with an else, to avoid
> duplicating the lock code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
> Not tested.  I have assumed that the calls to both variable_is_present and
> dup_variable_bug need to be out of the lock.
> 
>  drivers/firmware/efi/efivars.c |    5 ++---
>  drivers/firmware/efi/vars.c    |   23 ++++++++++-------------
>  fs/efivarfs/super.c            |    3 +--
>  include/linux/efi.h            |    3 +--
>  4 files changed, 14 insertions(+), 20 deletions(-)

Applied. Thanks Julia.