linux-kernel - Re: [PATCH] usb: serial: ti_usb_3410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160504074038.GC1367@localhost>
Date:	Wed, 4 May 2016 09:40:38 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0
 support

On Tue, May 03, 2016 at 01:46:51PM +0200, Mathieu OTHACEHE wrote:
> > No, I was trying to say that the we should not attempt to load a
> > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa
> > firmware.
> 
> For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw
> and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing.
> 
> So, I can patch the driver to request firmwares in this order :
> 
> 1. VID dependant (MTS and MOXA now)
> 2. ti_usb-v%04x-p%04x.fw format
> 3. Generic firmware
> 
> But, for generic firmware users, ti_usb-v%04x-p%04x.fw loading will
> still always fail ...
> 
> Or we can get rid of ti_usb-v%04x-p%04x.fw loading because no one has
> defined a firmware with this format in linux-firmware repository ?

Let's try to be conservative and not necessarily change the current
behaviour right away. Just make sure the Moxa firmware is loaded
directly, without fallback, and we can see about possibly cleaning up
the legacy behaviour later (in incremental patches that can easily be
reverted if anyone complains).

Thanks,
Johan