linux-kernel - Re: [PATCH] infoleak fix1 in signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160504103851.GA6977@redhat.com>
Date:	Wed, 4 May 2016 12:38:52 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Kangjie Lu <kangjielu@...il.com>
Cc:	akpm@...ux-foundation.org, peterz@...radead.org, amanieu@...il.com,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu, insu@...ech.edu,
	Kangjie Lu <kjlu@...ech.edu>
Subject: Re: [PATCH] infoleak fix1 in signal

On 05/03, Kangjie Lu wrote:
>
> The stack object “info” has a total size of 128 bytes; however,
> only 28 bytes are initialized. The remaining uninitialized bytes
> are sent to userland via send_signal.

Not really, please see copy_siginfo_to_user(), case(__SI_CHLD). All members
copied to user-space are initialized afaics.

> @@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  			sig = SIGCHLD;
>  	}
>
> +	memset(&info, 0, sizeof(info));

looks like a false alarm to me.

Oleg.