linux-kernel - Re: [PATCH REPOST] Extend PCIE_BUS_PEER2PEER to set MRSS=128 to fix CNS3xxx BM DMA.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3y47qdl6g.fsf@t19.piap.pl>
Date:	Wed, 04 May 2016 15:09:27 +0200
From:	khalasa@...p.pl (Krzysztof Hałasa)
To:	Bjorn Helgaas <helgaas@...nel.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, Arnd Bergmann <arnd@...db.de>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH REPOST] Extend PCIE_BUS_PEER2PEER to set MRSS=128 to fix CNS3xxx BM DMA.

Bjorn Helgaas <helgaas@...nel.org> writes:

> It looks like 498a92d42596 merely fixed a warning, at the expense of
> breaking DMA on Cavium.  Reverting it would bring the warning back, but
> that's better than broken DMA.

Perhaps we should change PCIE_BUS_PEER2PEER to also write MRRS anyway.

I realize the CNS3xxx patch is some sort of clever workaround, and that
PCIE_BUS_PEER2PEER (which normally comes from kernel command line
parameter "pcie_bus_peer2peer") was not exactly intended for this. But
if one asks for "peer2peer" (which means limiting transfers to 128
bytes), how could it all work if the bus mastering read requests are
not equally limited?

BTW s/MRSS/MRRS/g
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland