[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLUPR0701MB1572C01E91A88A475028FD38917B0@BLUPR0701MB1572.namprd07.prod.outlook.com>
Date: Wed, 4 May 2016 12:46:17 +0000
From: Konstantin Shkolnyy <Konstantin.Shkolnyy@...abs.com>
To: Johan Hovold <johan@...nel.org>,
Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic
numbers in CRTSCTS flag code.
> -----Original Message-----
> From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-
> owner@...r.kernel.org] On Behalf Of Johan Hovold
> Sent: Wednesday, May 04, 2016 02:29
> To: Konstantin Shkolnyy
> Cc: johan@...nel.org; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic
> numbers in CRTSCTS flag code.
>
> On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote:
> > Replaced magic numbers used in the CRTSCTS flag code with symbolic
> names
> > from the chip specification.
> >
> > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
>
> This patch does not even compile. Please be more careful when
> resubmitting. There are at least two compilation errors below.
Sorry about that.
It's a couple of dumb syntax errors that don't really matter for change review purpose. Otherwise, do the patches look good? I
[...]
Powered by blists - more mailing lists