linux-kernel - Re: [PATCH] efi/capsule: Make efi_capsule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160504133656.GJ2839@codeblueprint.co.uk>
Date:	Wed, 4 May 2016 14:36:56 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Kweh Hock Leong <hock.leong.kweh@...el.com>,
	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	joeyli <jlee@...e.com>
Subject: Re: [PATCH] efi/capsule: Make efi_capsule_pending() lockless

On Wed, 04 May, at 02:20:42PM, Borislav Petkov wrote:
> On Wed, May 04, 2016 at 12:46:05PM +0100, Matt Fleming wrote:
> > But emergency_restart() is called after bust_spinlocks(0) which can
> > reset oops_in_progress, so can't even use that to solve the panic
> > case.
> 
> Blergh.
> 
> So I guess you need an explicit call efi_stop_capsules() somewhere in
> the reboot path and be done with it. No reboot notifiers, no bla bla.
> Just one big hammer which STFU the EFI.

But you can't block in the reboot path and you can't guarantee you'll
interrupt an in-progress EFI capsule update call that started before
you entered the reboot path.