linux-kernel - Re: [PATCH 2/3] iio: bmi160: Fix ODR setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df9ec160-714b-72b7-cd9a-67bdd3092c89@kernel.org>
Date:	Wed, 4 May 2016 10:51:03 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: bmi160: Fix ODR setting

On 29/04/16 12:42, Daniel Baluta wrote:
> mask and val parameters of regmap_update_bits were reveresed.
> 
> Fixes: 77c4ad2d6a9 ("iio: imu: Add initial support for Bosch BMI160")
> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git.

Not pushed out as anything at all yet.

Jonathan
> ---
>  drivers/iio/imu/bmi160/bmi160_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> index cd9b75e..b8a290e 100644
> --- a/drivers/iio/imu/bmi160/bmi160_core.c
> +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> @@ -364,8 +364,8 @@ int bmi160_set_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>  
>  	return regmap_update_bits(data->regmap,
>  				  bmi160_regs[t].config,
> -				  bmi160_odr_table[t].tbl[i].bits,
> -				  bmi160_regs[t].config_odr_mask);
> +				  bmi160_regs[t].config_odr_mask,
> +				  bmi160_odr_table[t].tbl[i].bits);
>  }
>  
>  static int bmi160_get_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>