linux-kernel - Re: [PATCH 05/13] iio: health/afe440x: Fix scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2c4fafd-2fd0-ab63-df23-4a6fda897554@kernel.org>
Date:	Wed, 4 May 2016 11:03:27 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	"Andrew F. Davis" <afd@...com>, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>
Cc:	linux-iio@...r.kernel.org, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/13] iio: health/afe440x: Fix scan_index assignment

On 01/05/16 21:36, Andrew F. Davis wrote:
> The LED channels are not scannable and so scan_index should
> be negative, fix this here.
> 
> Signed-off-by: Andrew F. Davis <afd@...com>
Good point.  I've applied this to the togreg branch, but if
you want me to push this one out as a fix it definitely qualifies.

Jonathan
> ---
>  drivers/iio/health/afe440x.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
> index 544bbab..583d071 100644
> --- a/drivers/iio/health/afe440x.h
> +++ b/drivers/iio/health/afe440x.h
> @@ -125,7 +125,7 @@ struct afe440x_reg_info {
>  		.type = IIO_CURRENT,				\
>  		.channel = _index,				\
>  		.address = _index,				\
> -		.scan_index = _index,				\
> +		.scan_index = -1,				\
>  		.extend_name = _name,				\
>  		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |	\
>  			BIT(IIO_CHAN_INFO_SCALE),		\
>