linux-kernel - RE: [PATCH] ie31200_edac: add skylake support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2016 17:44:05 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Jason Baron <jbaron@...mai.com>, "bp@...en8.de" <bp@...en8.de>
CC:	"dougthompson@...ssion.com" <dougthompson@...ssion.com>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ie31200_edac: add skylake support

> I've verified that the 'ce_count' is correctly incrementing with bad dimms.

Did you re-test on at least one of the previous 3 generations of CPUs supported
by this driver?  All would be nice, but the bulk of the opportunities for cut&paste
errors seem to be in code that looks like:

	if (Skylake)
		do new thing
	else
		do old thing

so if one of them still works, it's likely they all do.

-Tony