linux-kernel - Re: [PATCH] PM / OPP: Remove useless check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160504182127.GR3492@codeaurora.org>
Date:	Wed, 4 May 2016 11:21:27 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rafael Wysocki <rjw@...ysocki.net>,
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
	linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
	Marc Gonzalez <marc_gonzalez@...madesigns.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / OPP: Remove useless check

On 05/04, Viresh Kumar wrote:
> Regulators are optional for devices using OPPs and the OPP core
> shouldn't be printing any errors for such missing regulators.
> 
> It was fine before the commit 0c717d0f9cb4, but that failed to update
> this part of the code to remove an 'always true' check and an extra
> unwanted print message.
> 
> Fix that now.
> 
> Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value")
> Reported-by: Marc Gonzalez <marc_gonzalez@...madesigns.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project