linux-kernel - Re: [PATCH 1/3] time: Add missing implementation for timespec64_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLX19AkyVcOnYNa6n40zeYBB7kuuQgVBLxUS0oZqNSSk8A@mail.gmail.com>
Date:	Wed, 4 May 2016 11:31:22 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Deepa Dinamani <deepa.kernel@...il.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
	y2038 Mailman List <y2038@...ts.linaro.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/3] time: Add missing implementation for timespec64_add_safe()

On Fri, Apr 29, 2016 at 9:39 AM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
> timespec64_add_safe() has been defined in time64.h for
> 64 bit systems.
> But, 32 bit systems only have an extern function prototype defined.
> Provide a definition for the above function.
>
> The function will be necessary as part of y2038 changes.
> struct timespec is not y2038 safe. All references to timespec will
> be replaced by struct timespec64. The function is meant to be a
> replacement for timespec_add_safe().
>
> The implementation is similar to timespec_add_safe().
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> ---
>  include/linux/time64.h |  4 +---
>  kernel/time/time.c     | 25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 3 deletions(-)

Looks ok at the first glance. I've queued these up for testing,
however I only got #1 and #3 of the set. Are you hoping these two
patches will go through tip/timers/core or are you looking for acks so
they can go via another tree?

thanks
-john