linux-kernel - Re: [PATCH] ACPI / amba: Remove CLK_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 May 2016 23:11:51 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	G Gregory <graeme.gregory@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Len Brown <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Aleksey Makarov <aleksey.makarov@...aro.org>
Subject: Re: [PATCH] ACPI / amba: Remove CLK_IS_ROOT

On Wednesday, April 20, 2016 08:28:38 AM G Gregory wrote:
> On 20 April 2016 at 02:28, Stephen Boyd <sboyd@...eaurora.org> wrote:
> > This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
> > CLK_IS_ROOT", 2016-02-02) so remove it.
> >
> > Cc: Graeme Gregory <graeme.gregory@...aro.org>
> > Cc: Aleksey Makarov <aleksey.makarov@...aro.org>
> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> > ---
> >  drivers/acpi/acpi_amba.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c
> > index 2a61b54ab968..7f77c071709a 100644
> > --- a/drivers/acpi/acpi_amba.c
> > +++ b/drivers/acpi/acpi_amba.c
> > @@ -35,8 +35,7 @@ static void amba_register_dummy_clk(void)
> >         if (amba_dummy_clk)
> >                 return;
> >
> > -       amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL,
> > -                                               CLK_IS_ROOT, 0);
> > +       amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, 0, 0);
> >         clk_register_clkdev(amba_dummy_clk, "apb_pclk", NULL);
> >  }
> >
> Looks good to me.
> 
> Acked-by: Graeme Gregory <graeme.gregory@...aro.org>

Applied, thanks!