linux-kernel - Re: [PATCH 1/1] drivers: acpi: add CPU id to cooling device type of processor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2680812.8DqCpBTJz8@vostro.rjw.lan>
Date:	Thu, 05 May 2016 00:00:57 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Eduardo Valentin <edubezval@...il.com>
Cc:	"Rafael J. Wysocki" <rafael@...nel.org>,
	Rui Zhang <rui.zhang@...el.com>,
	Linux PM <linux-pm@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] drivers: acpi: add CPU id to cooling device type of processor driver

On Wednesday, May 04, 2016 02:54:32 PM Srinivas Pandruvada wrote:
> On Wed, 2016-05-04 at 23:49 +0200, Rafael J. Wysocki wrote:
> > On Tue, May 3, 2016 at 7:04 AM, Eduardo Valentin <edubezval@...il.com
> > > wrote:
> > > 
> > > Currently, in an ACPI based system, the processor driver registers
> > > one cooling device per processor. However, the cooling device type
> > > is the same for each processor. For example, on a system with four
> > > processors, the sysfs reading of each cooling device would look
> > > like:
> > > ebv@...ouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > > Processor
> > > Processor
> > > Processor
> > > Processor
> > > 
> > > which turns out to fine. But, some parts of the thermal code may
> > > use
> > > type to identify participating devices in a thermal zone. Besides,
> > > adding notifications to user space may cause the production of
> > > messages
> > > that may confuse the listener.
> > > 
> > > For this reason, this patch adds the processor ID cooling device
> > > type.
> > > After this change, the cooling device listing in the same previous
> > > example
> > > would look like this:
> > > ebv@...ouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > > Processor.0
> > > Processor.1
> > > Processor.2
> > > Processor.3
> > > 
> > > allowing an easier identification of cooling device target.
> > 
> > Is it not going to confuse any user space scripts or similar?
>
> Yes, it will.

In that case the patch cannot be applied.

Thanks,
Rafael