linux-kernel - Re: [PATCH v5 0/3] USB: serial: cp210x: Bugfixes and cleanup in CRTSCTS flag code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 12:00:10 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
Cc:	johan@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/3] USB: serial: cp210x: Bugfixes and cleanup in
 CRTSCTS flag code

On Wed, May 04, 2016 at 04:56:38PM -0500, Konstantin Shkolnyy wrote:
> This patch series fixes bugs and replaces magic numbers with symbolic
> names in CRTSCTS flag code.
> 
> v5:
> Fixed 2 compile errors in PATCH 2/3, otherwise no change.
> v4:
> Same series of patches, fixed names and defines by feedback.
> v3:
> Regenerated the patches correctly against the latest usb-next branch.
> v2
> Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
> 
> Konstantin Shkolnyy (3):
>   USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.
>   USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
>   USB: serial: cp210x: Cleaned up CRTSCTS flag code.
> 
>  drivers/usb/serial/cp210x.c | 102 ++++++++++++++++++++++++++++++++------------
>  1 file changed, 74 insertions(+), 28 deletions(-)

Thanks for the v5. All now applied for -next.

I reworded the first commit message slightly and added a stable tag
since it clearly fixes a bug even if it happens to have been around
since 2005 without anyone noticing.

And thanks again for doing this work. The code is indeed much easier to
read now, and provides a good foundation for further improvements.

Johan