linux-kernel - Re: [PATCH] mm: slab: remove ZONE_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 13:49:46 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Yang Shi <yang.shi@...aro.org>
Cc:	cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
	iamjoonsoo.kim@....com, akpm@...ux-foundation.org,
	hannes@...xchg.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG

On Wed 04-05-16 10:01:37, Yang Shi wrote:
> Now we have IS_ENABLED helper to check if a Kconfig option is enabled or not,
> so ZONE_DMA_FLAG sounds no longer useful.
> 
> And, the use of ZONE_DMA_FLAG in slab looks pointless according to the
> comment [1] from Johannes Weiner, so remove them and ORing passed in flags with
> the cache gfp flags has been done in kmem_getpages().
> 
> [1] https://lkml.org/lkml/2014/9/25/553

I haven't checked the patch but I have a formal suggestion.
lkml.org tends to break and forget, please use
http://lkml.kernel.org/r/$msg-id instead. In this case
http://lkml.kernel.org/r/20140925185047.GA21089@cmpxchg.org

Thanks!
-- 
Michal Hocko
SUSE Labs