linux-kernel - Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1462457965.27137.93.camel@hpe.com>
Date:	Thu, 05 May 2016 08:19:25 -0600
From:	Toshi Kani <toshi.kani@....com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	dan.j.williams@...el.com, david@...morbit.com, jack@...e.cz,
	linux-nvdimm@...1.01.org, linux-kernel@...r.kernel.org,
	micah.parrish@....com, adilger.kernel@...ger.ca,
	linux-fsdevel@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount

On Thu, 2016-05-05 at 07:21 -0700, Christoph Hellwig wrote:
> > 
> >  	if (mp->m_flags & XFS_MOUNT_DAX) {
> > +		struct blk_dax_ctl dax = {
> > +			.sector = 0,
> > +			.size = PAGE_SIZE,
> > +		};
>
> I'm pretty sure I already complained last week, but this boiler plate
> code has no business in every file systems.  Also it seems to me like
> this struct blk_dax_ctl calling convention is stupid to start with,
> why not pass the arguments directly and avoid the boilerplate code
> everywhere?

Sorry, I was wondering about if we should also consolidate error messages.
Per the thread below, I am going to add a helper function to do it.
https://lkml.org/lkml/2016/5/4/887

Thanks,
-Toshi