| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 May 2016 16:22:38 +0100
From: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To: Amitkumar Karwar <akarwar@...vell.com>
Cc: <linux-bluetooth@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Ganapathi Bhat <gbhat@...vell.com>
Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download
for Marvell
> +/* Send ACK/NAK to the device */
> +static void mrvl_send_ack(struct hci_uart *hu, unsigned char ack)
> +{
> + struct tty_struct *tty = hu->tty;
> +
> + tty->ops->write(tty, &ack, sizeof(ack));
> +}
You don't know if the device has a write method, and it should be locked.
This should go via your ldisc not directly.
Alan
Powered by blists - more mailing lists